USA
Asked — Edited

Elseif Is Broken

@DJ,

The ElseIf is broken:

The code below never stops !


$buffer="[123 456 789]"
$len=Length($buffer)
$ix=0
$start=-1
$end=-1
repeatwhile($ix<$len)
  $ch=GetCharAt($buffer, $ix)
  if ($ch="[")
    print("found start")
    $start=$ix
  elseif ($start>=0 AND $ch="]")
    print("found end")
    $end=$ix
    # break
    $ix=$len+1
  endif
  print("increment ix")
  $ix=$ix+1
endrepeatwhile
print($ix)
print($start)
print($end)

if you remove the ElseIf it works as expected.


$buffer="[123 456 789]"
$len=Length($buffer)
$ix=0
$start=-1
$end=-1
repeatwhile($ix<$len)
  $ch=GetCharAt($buffer, $ix)
  if ($ch="[")
    print("found start")
    $start=$ix
  endif
  if ($start>=0 AND $ch="]")
    print("found end")
    $end=$ix
    # break
    $ix=$len+1
  endif
  print("increment ix")
  $ix=$ix+1
endrepeatwhile
print($ix)
print($start)
print($end)

This bug must be recent, i've used before the ElseIf, or did i miss something ?


ARC Pro

Upgrade to ARC Pro

Stay on the cutting edge of robotics with ARC Pro, guaranteeing that your robot is always ahead of the game.

#1  

Does the ElseIf require its own EndIf?

This is one thing I've never been clear ablout EZ Script as other languages do require that but EZ Script doesn't seem to require it

PRO
USA
#2  

@faengelm:

No. Only one Endif for the If clause.

Tutorial: https://synthiam.com/Community/Tutorials/134/1

Quote:

other languages do require

Some languages have optional code blocks and don't need the endif: C, C#, Java { } TSQL: Begin ... End

Python uses indentation and sometimes is a pin a neck (tab vs spaces):


if expression1:
   statement(s)
elif expression2:
   statement(s)
elif expression3:
   statement(s)
else:
   statement(s)

Curiosity, what program language do you have in mind that requires 2 endifs ?

#3  

@ptp You are right. I was confused by the case where instead of an ElseIf there is an Else with a nested If ... Endif

#4  

Hi @PTP I tried the simplest

If ElseIF EndIf

I could think of and this is working both trying $a=1 and $a=2


$a=2

:loop
if ($a=1)
  Print( "$a= " + $a) 
elseif ($a=2)
  Print( "$a= " + $a)
endif
 
Sleep( 2000 ) 
Goto(loop)

I'm using ARC 2017.05.14

Maybe the ElseIf issue has been fixed

Regards, Frank

PRO
USA
#5  

Frank:

Did you tried my code and is working for you ? I just tried my code with the new version and the bug is still present.

Simple example 2 (broken):


$a=11
print("Start")
if ($a=1)
  print("one")
elseif ($a=3)
  print("three")
elseif ($a=5)
  print("five")
endif
print("End")

output: script does not stop and keeps printing "Start".

Simple example 3 s[/s] WORKING:


$a=11
print("***Start")
if ($a=1)
  print("one")
ELSEif ($a=3)
  print("three")
ELSEif ($a=5)
  print("five")
ELSE
  print("another number")
endif
print("End")

output: Start ***Start another number End

#EDIT: This example works, Start is not duplicated, i confused the second start with ARC Start

PRO
USA
#7  

Frank:

didn't took me long to break your code:)


$a=3

:loop
print("before")
if ($a=1)
  Print( "$a= " + $a)
ELSEif ($a=2)
  Print( "$a= " + $a)
endif
print("after")
Sleep( 2000 )
Goto(loop)

The code above is broken

#8  

I can confirm what @ptp is saying... None of his examples seem to work...

PRO
USA
#9  

@Richard R: Last version ?

#12  

@ptp You are right! I forgot to check the boundary conditions..

$A=3 breaks it with the latest ARC

I get the same "Start" message that you do

User-inserted image

Thanks, Frank

PRO
Synthiam
#13  

$a=11
print("Start")
if ($a=1)
  print("one")
ELSEif ($a=3)
  print("three")
ELSEif ($a=5)
  print("five")
ELSE
  print("another number")
endif
print("End")

Outputs (correct):

Quote:

Start Start another number End Done (00:00:00.0156256)



$a=3
print("Start")
if ($a=1)
  print("one")
ELSEif ($a=3)
  print("three")
ELSEif ($a=5)
  print("five")
ELSE
  print("another number")
endif
print("End")

Outputs (correct):

Quote:

Start Start three End Done (00:00:00.0155859)



$a=5
print("Start")
if ($a=1)
  print("one")
ELSEif ($a=3)
  print("three")
ELSEif ($a=5)
  print("five")
ELSE
  print("another number")
endif
print("End")

Outputs (correct):

Quote:

Start Start five End Done (00:00:00)

PRO
USA
#14  

@DJ,

It's fixed in your version ? Current version does not work.

PRO
Synthiam
#15  

I'm using the same version as you.

Your examples are all incorrect - surprised none of you caught any of the incorrectness:D

If you copy and paste my code into your copy of ARC, you will receive the same output. Copy and paste, do not type it because there's lots of mistakes being made in this thread example code. Such as the $a=11 lol

PRO
USA
#16  

@DJ:

What is the mistake in the code below ?


$a=11
print("***Start")
if ($a=1)
  print("one")
elseif ($a=3)
  print("three")
elseif ($a=5)
  print("five")
endif
print("***End")

the code above produces this:

User-inserted image

PRO
Synthiam
#17  

Let me take a look and see how this can be... stay tuned

#18  

An IF or ELSEIF needs an ELSE to finish the clause before the ENDIF.

You can make the ELSE do nothing, but it is still required (at least in EZ-Script. Might be implied in some languages).

Not sure this has always been the case, but it is the difference between the failing and the succeeding cases.

Alan

#20  

@ptp

Yeah, I edited my post to say I am not sure this has always been the case, but is the difference between the working and failing code. Was to point DJ towards cause of bug, not to say scripts were wrong.

Alan

PRO
USA
#21  

yes i agree with you.

it seems the problem is when the condition is false and no else is found.

OK:


print("***Start")
$a=1
repeatwhile($a<=9)
  if ($a=1)
    Print("1")
  ELSEif ($a=2)
    Print("2")
  ELSEif ($a=3)
    Print("3")
  ELSEif ($a<10)
    Print("less than 10 a="+$a)
  endif
  $a=$a+1
ENDrepeatwhile
print("***End")

User-inserted image

if you change the condition:


repeatwhile($a<=10)

it get lost forever:

User-inserted image

PRO
Synthiam
#22  

Fixed for next release (later tonight)...


$buffer="[123 456 789]"
$start=-1
$end=-1

repeat ($ix, 0, length($buffer) - 1, 1)

  $ch=GetCharAt($buffer, $ix)

  if ($ch = "[")

    print("found start")
    $start=$ix

  ELSEif ($ch = "]")

    print("found end")
    $end=$ix

  endif

ENDrepeat

print($start)
print($end)

Outputs:

Quote:

Start found start found end 0 12 Done (00:00:00.0337752)